1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
|
https://github.com/cracklib/cracklib/commit/a77a392272df3677f71c68e81fcdad1bc722732e
From a77a392272df3677f71c68e81fcdad1bc722732e Mon Sep 17 00:00:00 2001
From: Olivier Gayot <olivier.gayot@canonical.com>
Date: Thu, 30 Nov 2023 18:36:17 +0100
Subject: [PATCH] Fix test-suite so it can run with Python 3.12
The test suite still used the obsolete assertEquals() function which was
a deprecated alias for assertEqual() (without the s) and got dropped
from Python 3.12.
Use the replacement instead so the test-suite can run with Python 3.12.
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
--- a/python/test_cracklib.py
+++ b/python/test_cracklib.py
@@ -69,52 +69,52 @@ def test_simple(self):
def test_simple_lower(self):
for passwd in ['t' * i for i in range(
cracklib.MIN_LENGTH - cracklib.LOW_CREDIT)]:
- self.assertEquals(
+ self.assertEqual(
1, cracklib.simple(passwd),
'password {0} should be detected as too simple'.format(
passwd))
- self.assertEquals(0, cracklib.simple(
+ self.assertEqual(0, cracklib.simple(
't' * (cracklib.MIN_LENGTH - cracklib.LOW_CREDIT)))
def test_simple_upper(self):
for passwd in ['T' * i for i in range(
cracklib.MIN_LENGTH - cracklib.UP_CREDIT)]:
- self.assertEquals(
+ self.assertEqual(
1, cracklib.simple(passwd),
'password {0} should be detected as too simple'.format(
passwd))
- self.assertEquals(0, cracklib.simple(
+ self.assertEqual(0, cracklib.simple(
'T' * (cracklib.MIN_LENGTH - cracklib.UP_CREDIT)))
def test_simple_digit(self):
for passwd in ['1' * i for i in range(
cracklib.MIN_LENGTH - cracklib.DIG_CREDIT)]:
- self.assertEquals(
+ self.assertEqual(
1, cracklib.simple(passwd),
'password {0} should be detected as too simple'.format(
passwd))
- self.assertEquals(0, cracklib.simple(
+ self.assertEqual(0, cracklib.simple(
'1' * (cracklib.MIN_LENGTH - cracklib.DIG_CREDIT)))
def test_simple_other(self):
for passwd in ['#' * i for i in range(
cracklib.MIN_LENGTH - cracklib.OTH_CREDIT)]:
- self.assertEquals(
+ self.assertEqual(
1, cracklib.simple(passwd),
'password {0} should be detected as too simple'.format(
passwd))
- self.assertEquals(0, cracklib.simple(
+ self.assertEqual(0, cracklib.simple(
'#' * (cracklib.MIN_LENGTH - cracklib.OTH_CREDIT)))
def test_simple_combinations(self):
testset = '#a' * (cracklib.MIN_LENGTH // 2)
for passwd in [testset[:i] for i in range(
cracklib.MIN_LENGTH - cracklib.LOW_CREDIT - cracklib.OTH_CREDIT)]:
- self.assertEquals(
+ self.assertEqual(
1, cracklib.simple(passwd),
'password {0} should be detected as too simple'.format(
passwd))
- self.assertEquals(0, cracklib.simple(
+ self.assertEqual(0, cracklib.simple(
testset[:(cracklib.MIN_LENGTH - cracklib.LOW_CREDIT -
cracklib.OTH_CREDIT)]))
|
