blob: e6cd7e67442cb315155cb2ed5aa9b231d752a29b (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
|
# Check whether ebuilds are not installing new, non-Gentoo-ey paths.
# QA check: validate Gentoo's filesystem layout policies
# Maintainer: Portage team <dev-portage@gentoo.org>
gentoo_path_check() {
# allowed path definitions
# ------------------------
# directories common to / and /usr
local allowed_common_dirs=(
bin lib lib32 lib64 libx32 sbin
)
# toplevel directories which can be installed to by ebuilds
# /home is not included as no ebuilds should install files there
local allowed_paths_toplevel=(
"${allowed_common_dirs[@]}"
boot dev etc opt srv usr var
nix # sys-apps/nix, bug #670902
gnu # sys-apps/guix, bug #670902
)
# directories in /usr which can be installed to by ebuilds
# /usr/games is not included as it is banned nowadays
local allowed_paths_usr=(
"${allowed_common_dirs[@]}"
include libexec share src
# toolchain stuff
"${CHOST}" "${CTARGET}"
)
# the logic
# ---------
local bad_paths=()
local x
local shopt_save=$(shopt -p nullglob)
shopt -s nullglob
# 1. check for unexpected top-level directories
local toplevel_dirs=( "${ED%/}"/* )
for x in "${toplevel_dirs[@]##*/}"; do
if ! has "${x}" "${allowed_paths_toplevel[@]}"; then
bad_paths+=( "/${x}" )
fi
done
# 2. check for unexpected /usr subdirectories
local usr_dirs=( "${ED%/}"/usr/* )
for x in "${usr_dirs[@]##*/}"; do
if ! has "${x}" "${allowed_paths_usr[@]}"; then
bad_paths+=( "/usr/${x}" )
fi
done
# 3. check for unexpected /usr/share/doc subdirectories
local doc_dirs=( "${ED%/}"/usr/share/doc/* )
for x in "${doc_dirs[@]##*/}"; do
if [[ ${x} != ${PF} ]]; then
bad_paths+=( "/usr/share/doc/${x}" )
fi
done
${shopt_save}
# report
# ------
if [[ -n ${bad_paths[@]} ]]; then
eqawarn "The ebuild is installing to one or more unexpected paths:"
eqawarn
eqatag -v non-gentoo-paths "${bad_paths[@]}"
eqawarn
eqawarn "Please fix the ebuild to use correct FHS/Gentoo policy paths."
fi
}
gentoo_path_check
: # guarantee successful exit
# vim:ft=sh
|
