gentoo resync : 14.05.2020

6 files changed, 278 insertions, 88 deletions

diff --git a/net-irc/ngircd/Manifest b/net-irc/ngircd/Manifest
index 8d495183b2fb..be2309afa2c8 100644
--- a/net-irc/ngircd/Manifest
+++ b/net-irc/ngircd/Manifest
@@ -1,6 +1,8 @@
+AUX ngircd-25-fix-gcc-10.patch 1762 BLAKE2B ad5085da2c8f0fbc01e4fc77c4dc20c461cd8a3aad4dff78ace70d8673b8607f4621d80dd6bd122549882be1a9c3f461812617ebf59bce877ab4e87b9414e5b4 SHA512 73b07fc2fe5475fc7eb999f93504e2cfbbd1a2720335ae4332fd43e2621824626eb0df606585d9424df9e05a21416126692859fd1dc9689883960c8708bf3adf
+AUX ngircd-25-make-env.patch 2331 BLAKE2B c65567046e00f3dfa3e5c14e06071bf14fd28257eb799850610b7fe55c4a4745b766d754670be99f635a81239328c27ea3218e878e6f921f1601233e34d08539 SHA512 e32b5e852953cdff7f565e3dc2f521edbf25a42afca62f3fa76d8f33f72e4de96bb4b7b190d036dd573fef04879ecc891d3342353f8f46361c08943f85196329
 AUX ngircd.init-r1.d 388 BLAKE2B 10b6d4eb2cd39fe4e3087461cdc15f2ee8f1002e826552e145903b69e16ce46169a2dde19e03af38228ed9ede0473a828aa8cd123ab4a2b043fde448bb180954 SHA512 12e62e23899d1143a35e60bf983c319f72aa13c49123b497963f96317b2990cb2529919336da5a9b5c230e55479c289358261af92d25ef54bd19079908e18158
-DIST ngircd-23.tar.gz 517686 BLAKE2B 1e1d7386a95f22917e6f69ec43bc48a8031543c48d6141a16d81fd935dab47ae89d8bbc91d9d71a26b0a1d2fd2040feb478e773fcc2a3049061fc0b21c8bad18 SHA512 714fbb4af12335e62c615fa1e8de9c7366c4c6da6af9b334019ba900dce072067f7b08199de8c96aad5dd4b9b786b57d536ba9dc92c62b37d2ae11960dbd01b1
 DIST ngircd-24.tar.gz 524968 BLAKE2B 8ec0518d54f43a4c42fbf9744d217eb2aae498fe4f0010bce6ad68164037c2e55dc2b9681babce8ca5f7e26bac60a91389c63dab397d349dd4bcbcce6c2e9839 SHA512 66d1b9576c03d0a70be17a235f2da50ee661646cd428d18a6c61975407671dd4a3a545069258536773b27d4fb63523527366bbbf4f35cb08111dc60842924395
-EBUILD ngircd-23-r1.ebuild 1650 BLAKE2B dec05ba13a17143191e093b2956bc013b8517e52a7949cd5a0e9b7f0810834ce46b57bf06ed549b89a98fa32b4e6945bbab05cc393437cdd9d7ced38c2d69126 SHA512 9bd2d786f35f5bc0cc48db592c6c9bf1d921bf24a55924b947d625f9043b7a8f6d97377266385aeb3d4a4f982a98c4c8e71c03ebd48a81302eec31fdbf97ef66
+DIST ngircd-25.tar.gz 527886 BLAKE2B ab75c9a904fae8da4c89e07bd66bb000bc9b614e27269be3ac6f55254c77abeb2d6f7d0afc6d05630f7c548ea13d842d4c0376123035f9417eda55565a69dcec SHA512 0c96e97da312fe86c50007a72db03f85b9f79df053806f50badd07c7ca8e8bddd99adb478eab8be9630330707d7aa578b5d0bd3017b59bf4515319a64c29ea6c
 EBUILD ngircd-24.ebuild 1685 BLAKE2B eb31abc6faf507e55bf9a88abe98fd83eb4dd9fee3e580e0b9f9fb187c47b29a2b7ab16e11f347769ad82e4f4f495eccf5622205215f91b3d920e833f6d7d8d8 SHA512 66d47dd1029301755ae43fbfcc5d25930a3965011884c5c965a9bd6983e187d79086b182958b9bb7942232e7705e419f8aaa11ed334aebbb76a9d8d55caec4df
-MISC metadata.xml 259 BLAKE2B db253a70057f68a5b270f8133fd92ece2932276797ea0c1edb3f00a453610b6d880c8cebf35ee7cdbcd533433521b70851a7a4c296806ac6f3f5407bc144f667 SHA512 2b92154346053dfc4dbd911664a5fc8b7a72eb3a12fe191cf010cceb362a8eb36e42cbf52cc0f0843d5ffe24fd6c0082bd11b2e7e4fa900f7660e828c1daa1d9
+EBUILD ngircd-25.ebuild 2269 BLAKE2B 8ebaf779409d513b2cdd22506b8ae26382b8183b881e7729211413fb2a7d70b5979a97addd8514cce0dfee9891316f0fd051dbce0ef64833913407c79ea6e4c3 SHA512 e83e0e3865fbdb8bdf766baeb6b58fef197a7fc25ae12b8d758357ae6ac25c17989d4b842315e62d4353fbf3f6340ac12fa5c731883ea2248108a4db78b915aa
+MISC metadata.xml 632 BLAKE2B c27dd54558ef8f4670a5c888fbe81fffd77c20eb8e487a45bd61cfe8703fb3c379217e3ee8a0304a1b27eddc3a9fea0826b1cacd8c464a20fbd0bce43a109074 SHA512 27891662b1e62cd3d19faf621a3e06efcc0b51ad092cde32cf7cbf5817b7e7840cb57e948389547ecfbe70a022419dbe23b46870117ccb9c26da6581da426eb9
diff --git a/net-irc/ngircd/files/ngircd-25-fix-gcc-10.patch b/net-irc/ngircd/files/ngircd-25-fix-gcc-10.patch
new file mode 100644
index 000000000000..33e0d444bd56
--- /dev/null
+++ b/net-irc/ngircd/files/ngircd-25-fix-gcc-10.patch
@@ -0,0 +1,77 @@
+From f27827d7937375b5348107ca7427abf74c9eff3d Mon Sep 17 00:00:00 2001
+From: michi <michi+ngircd@dataswamp.org>
+Date: Tue, 14 Apr 2020 16:53:02 +0200
+Subject: [PATCH] Unbreak GCC 10 (-fno-common) build
+
+---
+ src/ngircd/conn.c   |  1 +
+ src/ngircd/conn.h   | 14 +++++++++++---
+ src/ngircd/ngircd.c |  1 +
+ src/portab/portab.h |  4 ++++
+ 4 files changed, 17 insertions(+), 3 deletions(-)
+
+diff --git a/src/ngircd/conn.c b/src/ngircd/conn.c
+index f62e9675..e14e6c08 100644
+--- a/src/ngircd/conn.c
++++ b/src/ngircd/conn.c
+@@ -10,6 +10,7 @@
+  */
+ 
+ #define CONN_MODULE
++#define CONN_MODULE_GLOBAL_INIT
+ 
+ #include "portab.h"
+ 
+diff --git a/src/ngircd/conn.h b/src/ngircd/conn.h
+index c642541f..869477f0 100644
+--- a/src/ngircd/conn.h
++++ b/src/ngircd/conn.h
+@@ -105,9 +105,17 @@ typedef struct _Connection
+ #endif
+ } CONNECTION;
+ 
+-GLOBAL CONNECTION *My_Connections;
+-GLOBAL CONN_ID Pool_Size;
+-GLOBAL long WCounter;
++
++#ifdef CONN_MODULE_GLOBAL_INIT
++CONNECTION *My_Connections;
++CONN_ID Pool_Size;
++long WCounter;
++#else
++extern CONNECTION *My_Connections;
++extern CONN_ID Pool_Size;
++extern long WCounter;
++#endif
++
+ 
+ #define CONNECTION2ID(x) (long)(x - My_Connections)
+ 
+diff --git a/src/ngircd/ngircd.c b/src/ngircd/ngircd.c
+index 7166640b..41255ca0 100644
+--- a/src/ngircd/ngircd.c
++++ b/src/ngircd/ngircd.c
+@@ -9,6 +9,7 @@
+  * Please read the file COPYING, README and AUTHORS for more information.
+  */
+ 
++#define GLOBAL_INIT
+ #include "portab.h"
+ 
+ /**
+diff --git a/src/portab/portab.h b/src/portab/portab.h
+index 70d5ed3e..43f2f907 100644
+--- a/src/portab/portab.h
++++ b/src/portab/portab.h
+@@ -102,7 +102,11 @@ typedef unsigned char bool;
+ #endif
+ 
+ #undef GLOBAL
++#ifdef GLOBAL_INIT
+ #define GLOBAL
++#else
++#define GLOBAL extern
++#endif
+ 
+ /* SPLint */
+ 
diff --git a/net-irc/ngircd/files/ngircd-25-make-env.patch b/net-irc/ngircd/files/ngircd-25-make-env.patch
new file mode 100644
index 000000000000..e6494c720079
--- /dev/null
+++ b/net-irc/ngircd/files/ngircd-25-make-env.patch
@@ -0,0 +1,75 @@
+--- a/Makefile.am	2016-09-18 18:01:30.000000000 -0000
++++ b/Makefile.am	2020-04-20 14:01:43.166312404 -0000
+@@ -25,13 +25,13 @@
+ 	rm -f config.log debian
+ 
+ testsuite:
+-	cd src/testsuite && make check
++	cd src/testsuite && ${MAKE} check
+ 
+ lint:
+-	cd src/ngircd && make lint
++	cd src/ngircd && ${MAKE} lint
+ 
+ srcdoc:
+-	cd doc && make srcdoc
++	cd doc && ${MAKE} srcdoc
+ 
+ have-xcodebuild:
+ 	@xcodebuild -project contrib/MacOSX/ngIRCd.xcodeproj -list \
+@@ -66,7 +66,7 @@
+ 	 --out ../../$(distdir).mpkg
+ 	rm -f $(distdir).mpkg.zip
+ 	zip -ro9 $(distdir).mpkg.zip $(distdir).mpkg
+-	make osxpkg-clean
++	${MAKE} osxpkg-clean
+ 
+ osxpkg-clean:
+ 	[ ! -r ngircd.dest ] || sudo -n rm -rf ngircd.dest
+@@ -74,12 +74,12 @@
+ 
+ osxpkg-dest: have-xcodebuild osxpkg-clean clean
+ 	./configure --prefix=/opt/ngircd
+-	make xcode
+-	make -C contrib/MacOSX de.barton.ngircd.plist
++	${MAKE} xcode
++	${MAKE} -C contrib/MacOSX de.barton.ngircd.plist
+ 	mkdir -p ngircd.dest/opt/ngircd/sbin
+-	DESTDIR="$$PWD/ngircd.dest" make -C doc install
+-	DESTDIR="$$PWD/ngircd.dest" make -C contrib install
+-	DESTDIR="$$PWD/ngircd.dest" make -C man install
++	DESTDIR="$$PWD/ngircd.dest" ${MAKE} -C doc install
++	DESTDIR="$$PWD/ngircd.dest" ${MAKE} -C contrib install
++	DESTDIR="$$PWD/ngircd.dest" ${MAKE} -C man install
+ 	cp contrib/MacOSX/build/Default/ngIRCd \
+ 	 ngircd.dest/opt/ngircd/sbin/ngircd
+ 	rm ngircd.dest/opt/ngircd/etc/ngircd.conf
+--- a/doc/Makefile.am	2016-01-16 13:23:40.000000000 -0000
++++ b/doc/Makefile.am	2020-04-20 14:05:45.316912143 -0000
+@@ -55,7 +55,7 @@
+ install-data-hook: $(static_docs) $(toplevel_docs) $(generated_docs)
+ 	$(MKDIR_P) -m 755 $(DESTDIR)$(sysconfdir)
+ 	@if [ ! -f $(DESTDIR)$(sysconfdir)/ngircd.conf ]; then \
+-	  make install-config; \
++	  ${MAKE} install-config; \
+ 	 fi
+ 	$(MKDIR_P) -m 755 $(DESTDIR)$(docdir)
+ 	for f in $(static_docs) $(toplevel_docs); do \
+@@ -75,7 +75,7 @@
+ uninstall-hook:
+ 	rm -rf $(DESTDIR)$(docdir)
+ 	@if cmp --silent sample-ngircd.conf $(DESTDIR)$(sysconfdir)/ngircd.conf; then \
+-	  make uninstall-config; \
++	  ${MAKE} uninstall-config; \
+ 	 else \
+ 	  echo; \
+ 	  echo " ** NOTE: Not uninstalling changed configuration file:"; \
+@@ -87,7 +87,7 @@
+ 	rm -f $(DESTDIR)$(sysconfdir)/ngircd.conf
+ 
+ srcdoc:
+-	make -C src srcdoc
++	${MAKE} -C src srcdoc
+ 
+ .PHONY: install-config uninstall-config srcdoc
+ 
diff --git a/net-irc/ngircd/metadata.xml b/net-irc/ngircd/metadata.xml
index 7f0bfef99296..fe32ef1d9ca8 100644
--- a/net-irc/ngircd/metadata.xml
+++ b/net-irc/ngircd/metadata.xml
@@ -1,8 +1,17 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
 <pkgmetadata>
-	<!-- maintainer-needed -->
+	<maintainer type="person">
+		<email>sam@cmpct.info</email>
+		<name>Sam James</name>
+	</maintainer>
+	<maintainer type="project">
+		<email>proxy-maint@gentoo.org</email>
+		<name>Proxy Maintainers</name>
+	</maintainer>
 	<use>
 		<flag name="ident">Enables support for <pkg>net-libs/libident</pkg></flag>
+		<flag name="irc-plus">Enables support for the IRC+ protocol (needs <pkg>virtual/libiconv</pkg>)</flag>
+		<flag name="strict-rfc">Strict RFC compliance; may harm compatibility</flag>
 	</use>
 </pkgmetadata>
diff --git a/net-irc/ngircd/ngircd-23-r1.ebuild b/net-irc/ngircd/ngircd-23-r1.ebuild
deleted file mode 100644
index 86154bf4dd49..000000000000
--- a/net-irc/ngircd/ngircd-23-r1.ebuild
+++ /dev/null
@@ -1,84 +0,0 @@
-# Copyright 1999-2019 Gentoo Authors
-# Distributed under the terms of the GNU General Public License v2
-
-EAPI="5"
-
-inherit autotools-utils eutils user
-
-DESCRIPTION="An IRC server written from scratch"
-HOMEPAGE="http://ngircd.barton.de/"
-SRC_URI="http://ngircd.barton.de/pub/${PN}/${P}.tar.gz"
-
-LICENSE="GPL-2"
-SLOT="0"
-KEYWORDS="amd64 x86 ~x64-macos"
-IUSE="debug gnutls iconv ident ipv6 libressl pam ssl tcpd zlib"
-
-RDEPEND="
-	iconv? ( virtual/libiconv )
-	ident? ( net-libs/libident )
-	pam? ( sys-libs/pam )
-	ssl? (
-		!gnutls? (
-			!libressl? ( dev-libs/openssl:0 )
-		)
-		gnutls? ( net-libs/gnutls )
-		libressl? ( dev-libs/libressl )
-	)
-	tcpd? ( sys-apps/tcp-wrappers )
-	zlib? ( sys-libs/zlib )
-"
-DEPEND="${RDEPEND}
-	>=sys-apps/sed-4
-"
-
-RESTRICT="test"
-
-src_configure() {
-	if ! use prefix; then
-		sed -i \
-			-e "s:;ServerUID = 65534:ServerUID = ngircd:" \
-			-e "s:;ServerGID = 65534:ServerGID = nogroup:" \
-			doc/sample-ngircd.conf.tmpl || die
-	fi
-
-	local myeconfargs=(
-		--docdir="${EPREFIX}"/usr/share/doc/${PF}
-		--sysconfdir="${EPREFIX}"/etc/ngircd
-		$(use_enable debug sniffer)
-		$(use_enable debug)
-		$(use_enable ipv6)
-		$(use_with iconv)
-		$(use_with ident)
-		$(use_with pam)
-		$(use_with tcpd tcp-wrappers)
-		$(use_with zlib)
-	)
-
-	if use ssl; then
-		myeconfargs+=(
-			$(use_with !gnutls openssl)
-			$(use_with gnutls)
-		)
-	else
-		myeconfargs+=(
-			--without-gnutls
-			--without-openssl
-		)
-	fi
-
-	autotools-utils_src_configure
-}
-
-src_install() {
-	autotools-utils_src_install
-
-	newinitd "${FILESDIR}"/ngircd.init-r1.d ngircd
-}
-
-pkg_postinst() {
-	if ! use prefix; then
-		enewuser ngircd
-		chown ngircd "${ROOT}"/etc/ngircd/ngircd.conf
-	fi
-}
diff --git a/net-irc/ngircd/ngircd-25.ebuild b/net-irc/ngircd/ngircd-25.ebuild
new file mode 100644
index 000000000000..da56e3240d4a
--- /dev/null
+++ b/net-irc/ngircd/ngircd-25.ebuild
@@ -0,0 +1,111 @@
+# Copyright 1999-2020 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=7
+
+# Bug: https://github.com/ngircd/ngircd/issues/261
+WANT_AUTOMAKE=1.11.6
+inherit autotools
+
+DESCRIPTION="An IRC server written from scratch"
+HOMEPAGE="https://ngircd.barton.de/"
+SRC_URI="https://arthur.barton.de/pub/${PN}/${P}.tar.gz"
+
+LICENSE="GPL-2"
+SLOT="0"
+KEYWORDS="~amd64 ~arm64 ~x86 ~x64-macos"
+IUSE="debug gnutls ident irc-plus +ipv6 libressl pam +ssl strict-rfc tcpd test zlib"
+
+RESTRICT="!test? ( test )"
+
+RDEPEND="
+	acct-user/ngircd
+	acct-group/ngircd
+	irc-plus? ( virtual/libiconv )
+	ident? ( net-libs/libident )
+	pam? ( sys-libs/pam )
+	ssl? (
+		gnutls? ( net-libs/gnutls:= )
+		!gnutls? (
+			!libressl? ( dev-libs/openssl:0= )
+			libressl? ( dev-libs/libressl:0= )
+		)
+	)
+	tcpd? ( sys-apps/tcp-wrappers )
+	zlib? ( sys-libs/zlib )
+"
+
+BDEPEND="sys-devel/automake:1.11"
+
+DEPEND="
+	${RDEPEND}
+	test? (
+		dev-tcltk/expect
+		net-misc/netkit-telnetd
+	)
+"
+
+PATCHES=(
+	"${FILESDIR}/${PN}-25-fix-gcc-10.patch"
+	"${FILESDIR}/${PN}-25-make-env.patch"
+)
+
+# Flaky test needs investigation (bug 719256)
+RESTRICT="test"
+
+src_prepare() {
+	default
+
+	if ! use prefix; then
+		sed -i \
+			-e "s:;ServerUID = 65534:ServerUID = ngircd:" \
+			-e "s:;ServerGID = 65534:ServerGID = ngircd:" \
+			doc/sample-ngircd.conf.tmpl || die
+	fi
+
+	# Once https://github.com/ngircd/ngircd/pull/270 is in a release (ngircd 26), we can remove
+	# the eautomake/autotools machinery.
+	eautomake
+}
+
+src_configure() {
+	local myconf=(
+		--sysconfdir="${EPREFIX}"/etc/"${PN}"
+		$(use_enable debug sniffer)
+		$(use_enable debug)
+		$(use_enable irc-plus ircplus)
+		$(use_enable ipv6)
+		$(use_enable strict-rfc)
+		$(use_with irc-plus iconv)
+		$(use_with ident)
+		$(use_with pam)
+		$(use_with tcpd tcp-wrappers)
+		$(use_with zlib)
+	)
+
+	if use ssl; then
+		if use gnutls; then
+			myconf+=(
+				$( use_with gnutls )
+			)
+		else
+			myconf+=(
+				$( use_with !gnutls openssl )
+			)
+		fi
+	fi
+
+	econf "${myconf[@]}"
+}
+
+src_install() {
+	default
+	newinitd "${FILESDIR}"/ngircd.init-r1.d ngircd
+}
+
+pkg_postinst() {
+	if [[ -z ${REPLACING_VERSIONS} ]] && use pam; then
+		elog "ngircd will use PAMOnly by default, please change this option."
+		elog "You may not be able to login until you change this."
+	fi
+}