summaryrefslogtreecommitdiff
path: root/src/backend/binhost.py
diff options
context:
space:
mode:
authorV3n3RiX <venerix@koprulu.sector>2022-09-16 01:06:50 +0100
committerV3n3RiX <venerix@koprulu.sector>2022-09-16 01:06:50 +0100
commit96423b52302a01fa3a4922961bd8e072a5c46e15 (patch)
treed31bdfd6415b4dec2cd427024435ef2ce47669ac /src/backend/binhost.py
parentd5f7286a28caf0a7f628c09b515e7ed59a1a85fb (diff)
bugfix :
* subprocess.Popen child processes can "sometimes" generate a very large output, causing a deadlock (**cough** dependency solver **cough**) * use subprocess.Popen.communicate instead of subprocess.Popen.wait to avoid such issues * see : https://docs.python.org/3/library/subprocess.html#subprocess.Popen.wait
Diffstat (limited to 'src/backend/binhost.py')
-rw-r--r--src/backend/binhost.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/binhost.py b/src/backend/binhost.py
index 91a6e53..3de4fca 100644
--- a/src/backend/binhost.py
+++ b/src/backend/binhost.py
@@ -5,11 +5,11 @@ import subprocess
def start():
isBinhost = []
- portageExec = subprocess.Popen(['emerge', '--info', '--verbose'], stdout=subprocess.PIPE)
+ portageExec = subprocess.Popen(['emerge', '--info', '--verbose'], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+ stdout, stderr = portageExec.communicate()
for portageOutput in io.TextIOWrapper(portageExec.stdout, encoding="utf-8"):
if "PORTAGE_BINHOST" in portageOutput.rstrip():
isBinhost = str(portageOutput.rstrip().split("=")[1].strip('\"'))
- portageExec.wait()
return isBinhost