From 96423b52302a01fa3a4922961bd8e072a5c46e15 Mon Sep 17 00:00:00 2001 From: V3n3RiX Date: Fri, 16 Sep 2022 01:06:50 +0100 Subject: bugfix : * subprocess.Popen child processes can "sometimes" generate a very large output, causing a deadlock (**cough** dependency solver **cough**) * use subprocess.Popen.communicate instead of subprocess.Popen.wait to avoid such issues * see : https://docs.python.org/3/library/subprocess.html#subprocess.Popen.wait --- src/backend/binhost.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/backend/binhost.py') diff --git a/src/backend/binhost.py b/src/backend/binhost.py index 91a6e53..3de4fca 100644 --- a/src/backend/binhost.py +++ b/src/backend/binhost.py @@ -5,11 +5,11 @@ import subprocess def start(): isBinhost = [] - portageExec = subprocess.Popen(['emerge', '--info', '--verbose'], stdout=subprocess.PIPE) + portageExec = subprocess.Popen(['emerge', '--info', '--verbose'], stdout=subprocess.PIPE, stderr=subprocess.PIPE) + stdout, stderr = portageExec.communicate() for portageOutput in io.TextIOWrapper(portageExec.stdout, encoding="utf-8"): if "PORTAGE_BINHOST" in portageOutput.rstrip(): isBinhost = str(portageOutput.rstrip().split("=")[1].strip('\"')) - portageExec.wait() return isBinhost -- cgit v1.2.3