1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
|
From 7fd67692faf502663c001b38e48083c68876085b Mon Sep 17 00:00:00 2001
From: Stefan <96178532+stefan6419846@users.noreply.github.com>
Date: Mon, 29 Jan 2024 15:43:52 +0100
Subject: [PATCH 1/2] TST: Avoid catching not emitted warnings
---
tests/test_reader.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/test_reader.py b/tests/test_reader.py
index 98f73a01c..ad289c296 100644
--- a/tests/test_reader.py
+++ b/tests/test_reader.py
@@ -335,7 +335,7 @@ def test_get_images_raw(
)
pdf_stream = io.BytesIO(pdf_data)
if should_fail:
- with pytest.raises(PdfReadError) as exc, pytest.warns(PdfReadWarning):
+ with pytest.raises(PdfReadError) as exc:
PdfReader(pdf_stream, strict=strict)
assert exc.type == PdfReadError
if startx_correction == -1:
@@ -530,7 +530,7 @@ def test_read_prev_0_trailer():
pdf_data.find(b"xref") - 1,
)
pdf_stream = io.BytesIO(pdf_data)
- with pytest.raises(PdfReadError) as exc, pytest.warns(PdfReadWarning):
+ with pytest.raises(PdfReadError) as exc:
PdfReader(pdf_stream, strict=True)
assert exc.value.args[0] == "/Prev=0 in the trailer (try opening with strict=False)"
@@ -607,7 +607,7 @@ def test_read_unknown_zero_pages(caplog):
"Xref table not zero-indexed. ID numbers for objects will be corrected.",
]
assert normalize_warnings(caplog.text) == warnings
- with pytest.raises(PdfReadError) as exc, pytest.warns(PdfReadWarning):
+ with pytest.raises(PdfReadError) as exc:
len(reader.pages)
assert exc.value.args[0] == "Could not find object."
@@ -617,7 +617,7 @@ def test_read_unknown_zero_pages(caplog):
"startxref on same line as offset",
]
assert normalize_warnings(caplog.text) == warnings
- with pytest.raises(AttributeError) as exc, pytest.warns(PdfReadWarning):
+ with pytest.raises(AttributeError) as exc:
len(reader.pages)
assert exc.value.args[0] == "'NoneType' object has no attribute 'get_object'"
@@ -687,7 +687,7 @@ def test_issue604(caplog, strict):
outline = None
if strict:
pdf = PdfReader(f, strict=strict)
- with pytest.raises(PdfReadError) as exc, pytest.warns(PdfReadWarning):
+ with pytest.raises(PdfReadError) as exc:
outline = pdf.outline
if "Unknown Destination" not in exc.value.args[0]:
raise Exception("Expected exception not raised")
From 259128c25e25e23f284267d0abb9d7f1bd932de5 Mon Sep 17 00:00:00 2001
From: Stefan <96178532+stefan6419846@users.noreply.github.com>
Date: Mon, 29 Jan 2024 15:46:34 +0100
Subject: [PATCH 2/2] remove now unused import
---
tests/test_reader.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/test_reader.py b/tests/test_reader.py
index ad289c296..c9c6be9b3 100644
--- a/tests/test_reader.py
+++ b/tests/test_reader.py
@@ -17,7 +17,6 @@
EmptyFileError,
FileNotDecryptedError,
PdfReadError,
- PdfReadWarning,
WrongPasswordError,
)
from pypdf.generic import (
|
