diff options
author | V3n3RiX <venerix@redcorelinux.org> | 2019-04-28 09:54:45 +0100 |
---|---|---|
committer | V3n3RiX <venerix@redcorelinux.org> | 2019-04-28 09:54:45 +0100 |
commit | b7ebc951da8800f711142f69d9d958bde67a112d (patch) | |
tree | e318514216845acb8f2e49fff7a5cba4027e9d91 /kde-frameworks/kpackage/files/kpackage-5.57.0-runtime-crashfix.patch | |
parent | dc7cbdfa65fd814b3b9aa3c56257da201109e807 (diff) |
gentoo resync : 28.04.2019
Diffstat (limited to 'kde-frameworks/kpackage/files/kpackage-5.57.0-runtime-crashfix.patch')
-rw-r--r-- | kde-frameworks/kpackage/files/kpackage-5.57.0-runtime-crashfix.patch | 42 |
1 files changed, 42 insertions, 0 deletions
diff --git a/kde-frameworks/kpackage/files/kpackage-5.57.0-runtime-crashfix.patch b/kde-frameworks/kpackage/files/kpackage-5.57.0-runtime-crashfix.patch new file mode 100644 index 000000000000..5d13d3f8c3a3 --- /dev/null +++ b/kde-frameworks/kpackage/files/kpackage-5.57.0-runtime-crashfix.patch @@ -0,0 +1,42 @@ +From c3e896e02f9a8dc92d6e26cdbc87fe5c6b9cf3bf Mon Sep 17 00:00:00 2001 +From: David Faure <faure@kde.org> +Date: Sun, 14 Apr 2019 19:44:50 +0200 +Subject: Don't use qAsConst over a temporary variable + +Summary: +(will crash because the temporary will be destroyed before being used) + +Detected with + ag -sr qAsConst'\([^)]*\(' . + +Test Plan: builds + +Reviewers: mlaurent, cfeck, apol + +Reviewed By: mlaurent + +Subscribers: kde-frameworks-devel + +Tags: #frameworks + +Differential Revision: https://phabricator.kde.org/D20552 +--- + src/kpackage/package.cpp | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/src/kpackage/package.cpp b/src/kpackage/package.cpp +index 130eec6..801f1c2 100644 +--- a/src/kpackage/package.cpp ++++ b/src/kpackage/package.cpp +@@ -429,7 +429,8 @@ QStringList Package::entryList(const QByteArray &key) const + QStringList list; + for (const QString &prefix : qAsConst(d->contentsPrefixPaths)) { + //qCDebug(KPACKAGE_LOG) << " looking in" << prefix; +- for (const QString &path : qAsConst(it.value().paths)) { ++ const QStringList paths = it.value().paths; ++ for (const QString &path : paths) { + //qCDebug(KPACKAGE_LOG) << " looking in" << path; + if (it.value().directory) { + //qCDebug(KPACKAGE_LOG) << "it's a directory, so trying out" << d->path + prefix + path; +-- +cgit v1.1 |