From 96423b52302a01fa3a4922961bd8e072a5c46e15 Mon Sep 17 00:00:00 2001 From: V3n3RiX Date: Fri, 16 Sep 2022 01:06:50 +0100 Subject: bugfix : * subprocess.Popen child processes can "sometimes" generate a very large output, causing a deadlock (**cough** dependency solver **cough**) * use subprocess.Popen.communicate instead of subprocess.Popen.wait to avoid such issues * see : https://docs.python.org/3/library/subprocess.html#subprocess.Popen.wait --- src/backend/autoremove.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/backend/autoremove.py') diff --git a/src/backend/autoremove.py b/src/backend/autoremove.py index 5c2ee7a..37ae7ee 100644 --- a/src/backend/autoremove.py +++ b/src/backend/autoremove.py @@ -10,19 +10,19 @@ import sisyphus.killportage def start(): if sisyphus.check.root(): - portageExec = subprocess.Popen(['emerge', '--quiet', '--depclean', '--ask']) - portageExec.wait() + portageExec = subprocess.Popen(['emerge', '--quiet', '--depclean', '--ask'], stdout=subprocess.PIPE, stderr=subprocess.PIPE) + stdout, stderr = portageExec.communicate() sisyphus.database.syncLocal() else: sys.exit("\nYou need root permissions to do this, exiting!\n") def startqt(): - portageExec = subprocess.Popen(['emerge', '--depclean'], stdout=subprocess.PIPE) + portageExec = subprocess.Popen(['emerge', '--depclean'], stdout=subprocess.PIPE, stderr=subprocess.PIPE) + stdout, stderr = portageExec.communicate() # kill portage if the program dies or it's terminated by the user atexit.register(sisyphus.killportage.start, portageExec) for portageOutput in io.TextIOWrapper(portageExec.stdout, encoding="utf-8"): print(portageOutput.rstrip()) - portageExec.wait() sisyphus.database.syncLocal() -- cgit v1.2.3